Code review comment for lp://qastaging/~robru/notify-osd/inline-packaging

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

oh, and meanwhile, about the packaging:

878 +include /usr/share/cdbs/1/rules/autoreconf.mk
879 +include /usr/share/cdbs/1/class/gnome.mk
880 +include /usr/share/cdbs/1/rules/debhelper.mk
881 +

-> this is using cdbs (see the cdbs depends in debian/control), would be cool to use the full debhelper 9 capabilities, meaning removing the cdbs build-dep and changing debian/rules to have the traditional dh calls and overrides :)

review: Needs Fixing

« Back to merge proposal