Code review comment for lp://qastaging/~rodrigo-moya/unity/ref-state-set-for-panel-service

Revision history for this message
Alejandro PiƱeiro (apinheiro) wrote :

183 + else
184 + {
185 + atk_state_set_remove_state (state_set, ATK_STATE_ACTIVE);
186 + atk_state_set_remove_state (state_set, ATK_STATE_FOCUSED);
187 + atk_state_set_remove_state (state_set, ATK_STATE_SHOWING);
188 + }

Why you need to remove it? As I said, normally the state_set is created new, and empty. This should be only required if you suspect that any of his parents is adding those states. This is really unlikely, as the parent is AtkObject.

Other than that, the code seems ok.

review: Approve

« Back to merge proposal