Code review comment for lp://qastaging/~rodrigo-moya/unity/sync-geometries

Revision history for this message
Alejandro PiƱeiro (apinheiro) wrote :

519 + root = atk_get_root ();
520 +
521 gtk_main ();

This get_root could mean a crash if the a11y is not enabled. So options:

a) Add a method on panel-a11y to check if the accessibility is enabled.
b) Move this call inside panel_a11y_init. As it is required that the service is created to this root, that would mean move panel_a11y_init to the line of this atk_get_root

review: Needs Fixing

« Back to merge proposal