Code review comment for lp://qastaging/~rpadovani/webbrowser-app/no-duplicates-address-bar

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Sorry, I'm not sure I understand how to create a generic approach. We have 3 model to merge here: bookmarks, history, and suggestions on google. We want to limit bookmarks and history to two elements, suggestions on google to 5. I need to pass more elements to be sure the aren't doublons (4 is perfect for history, because at least two are different from the two of bookmarks), but how can I limit how many of them I display without counting how many I've already added in that section?

Maybe I've to do a more generic approach creating an array of how many of each section I added? But again, how could I choose if I have to display 5 or 2 without verifing which model it is?

« Back to merge proposal