Code review comment for lp://qastaging/~rpadovani/webbrowser-app/no-duplicates-address-bar

Revision history for this message
Olivier Tilloy (osomon) wrote :

Without looking further into the failures, my guess is that with your changes the suggestions are instantiated but not displayed. Autopilot, if not explicitly instructed to do so, will return all matching objects, regardless of whether they are visible or not.

If my guess is correct, there are two possible approaches here:
 - ensure that only exactly the required number of suggestions is instantiated
 - modify the autopilot emulator to query for only *visible* suggestions (have a look at tests/autopilot/webbrowser_app/emulators/browser.py around line 350)

« Back to merge proposal