Merge lp://qastaging/~rsalveti/linaro-image-tools/depmod-dont-fail into lp://qastaging/linaro-image-tools/11.11

Proposed by Ricardo Salveti
Status: Merged
Merged at revision: 548
Proposed branch: lp://qastaging/~rsalveti/linaro-image-tools/depmod-dont-fail
Merge into: lp://qastaging/linaro-image-tools/11.11
Diff against target: 11 lines (+1/-1)
1 file modified
linaro-hwpack-install (+1/-1)
To merge this branch: bzr merge lp://qastaging/~rsalveti/linaro-image-tools/depmod-dont-fail
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Fathi Boudra Pending
Review via email: mp+120053@code.qastaging.launchpad.net

Description of the change

Simple change, just to avoid failing in case depmod fails for some reason.

Having the modules in place is important, but not critical to get the images running (as generally only zimage/uimage is enough).

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Sounds reasonable.

review: Approve
Revision history for this message
Loïc Minier (lool) wrote :

Sorry, missed this while I was away

Hmm why would depmod fail? if it's not needed, then we should just remove it; if it's needed then it should work

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

On Sun, Aug 26, 2012 at 12:39 PM, Loïc Minier <email address hidden> wrote:
> Sorry, missed this while I was away
>
> Hmm why would depmod fail? if it's not needed, then we should just remove it; if it's needed then it should work

It can fail at the OE case if it's using kmod instead of
module-init-tools, as the update-alternatives link is just set later
after first boot. Here's it's not an issue if it fails, as the system
will still boot and work, just that until the first boot is done, the
modules will not be mapped.

Revision history for this message
Loïc Minier (lool) wrote :

On Sun, Aug 26, 2012, Ricardo Salveti wrote:
> It can fail at the OE case if it's using kmod instead of
> module-init-tools, as the update-alternatives link is just set later
> after first boot. Here's it's not an issue if it fails, as the system
> will still boot and work, just that until the first boot is done, the
> modules will not be mapped.

(I'm not familiar with this, but why is update-alternatives run after
boot? Is this because we don't have QEMU?)

Could we do the kmod equivalent first?
    kmod-depmod -a || depmod -a

--
Loïc Minier

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

On Sun, Aug 26, 2012 at 1:31 PM, Loïc Minier <email address hidden> wrote:
> On Sun, Aug 26, 2012, Ricardo Salveti wrote:
>> It can fail at the OE case if it's using kmod instead of
>> module-init-tools, as the update-alternatives link is just set later
>> after first boot. Here's it's not an issue if it fails, as the system
>> will still boot and work, just that until the first boot is done, the
>> modules will not be mapped.
>
> (I'm not familiar with this, but why is update-alternatives run after
> boot? Is this because we don't have QEMU?)

Yup.

> Could we do the kmod equivalent first?
> kmod-depmod -a || depmod -a

Kmod will try to find itself at it's default location, and as
everything is just set-up correctly after update-alternatives, it'll
not work. So instead of trying to call update-alternatives by hand (at
this point we're just configuring the image, without necessarily qemu
support), I just decided to not fail at this point, and later try to
make kmod the default option for OE without update-alternatives.

Revision history for this message
Loïc Minier (lool) wrote :

On Sun, Aug 26, 2012, Ricardo Salveti wrote:
> Kmod will try to find itself at it's default location, and as
> everything is just set-up correctly after update-alternatives, it'll
> not work. So instead of trying to call update-alternatives by hand (at
> this point we're just configuring the image, without necessarily qemu
> support), I just decided to not fail at this point, and later try to
> make kmod the default option for OE without update-alternatives.

Makes sense!

I wonder whether we want some kind of "--no-qemu" flag to this part of
linaro-image-tools, meaning "image will configure itself on first boot".

--
Loïc Minier

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

On Sun, Aug 26, 2012 at 7:58 PM, Loïc Minier <email address hidden> wrote:
> On Sun, Aug 26, 2012, Ricardo Salveti wrote:
>> Kmod will try to find itself at it's default location, and as
>> everything is just set-up correctly after update-alternatives, it'll
>> not work. So instead of trying to call update-alternatives by hand (at
>> this point we're just configuring the image, without necessarily qemu
>> support), I just decided to not fail at this point, and later try to
>> make kmod the default option for OE without update-alternatives.
>
> Makes sense!
>
> I wonder whether we want some kind of "--no-qemu" flag to this part of
> linaro-image-tools, meaning "image will configure itself on first boot".

We'll need such feature for ARMv8, so we'll be creating it in the next
following weeks :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches