Code review comment for lp://qastaging/~rsalveti/linaro-image-tools/depmod-dont-fail

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

On Sun, Aug 26, 2012 at 1:31 PM, Loïc Minier <email address hidden> wrote:
> On Sun, Aug 26, 2012, Ricardo Salveti wrote:
>> It can fail at the OE case if it's using kmod instead of
>> module-init-tools, as the update-alternatives link is just set later
>> after first boot. Here's it's not an issue if it fails, as the system
>> will still boot and work, just that until the first boot is done, the
>> modules will not be mapped.
>
> (I'm not familiar with this, but why is update-alternatives run after
> boot? Is this because we don't have QEMU?)

Yup.

> Could we do the kmod equivalent first?
> kmod-depmod -a || depmod -a

Kmod will try to find itself at it's default location, and as
everything is just set-up correctly after update-alternatives, it'll
not work. So instead of trying to call update-alternatives by hand (at
this point we're just configuring the image, without necessarily qemu
support), I just decided to not fail at this point, and later try to
make kmod the default option for OE without update-alternatives.

« Back to merge proposal