Code review comment for lp://qastaging/~sao/unity/show_launcher_in_navmode

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Olivier, thanks for the patch again!

So, I merged it into on of my "fix launcher" branch and we'll get it to trunk and released today :)
I've made some modification to your branch though:
- the OnActionDone is set when you click on an item, not when the launcher is shown, I've change the place of the call.

You can particularly see this with a hidden launcher at start:
press alt + F1 -> no focus (need to use down arrow key).
Also, we want to hide the launcher when a key is pressed, as with the mouse.

- think to prepend a space before () as it's done through the code, we are following GNOME code rules for that.

I've fix those, no worry! Thanks again for your work there.

I will work a little more on some other launcher fixes, then, I'll paste here the link of the merge :)

review: Approve

« Back to merge proposal