OpenStack Compute (nova)

Merge lp://qastaging/~sateesh-chodapuneedi/nova/lp759762 into lp://qastaging/~hudson-openstack/nova/trunk

lp759762
Merge into trunk

Proposed by Sateesh on 2011-04-14

Status:

Work in progress

Proposed branch:

lp://qastaging/~sateesh-chodapuneedi/nova/lp759762

Merge into:

lp://qastaging/~hudson-openstack/nova/trunk

Diff against target:

56 lines (+28/-0)

2 files modified

nova/virt/vmwareapi/vmops.py (+24/-0)
nova/virt/vmwareapi_conn.py (+4/-0)

To merge this branch:

bzr merge lp://qastaging/~sateesh-chodapuneedi/nova/lp759762

Medium

Invalid

Link a bug report

Reviewer	Review Type	Date Requested	Status
Matt Dietz (community)		2011-04-14	Needs Fixing on 2011-04-19
Review via email: mp+57625@code.qastaging.launchpad.net

Description of the change

Implemented method "list_instances_detail" in VMWareVMOps class. This will be called from compute/manager.py as part of instance polling task.

Earlier the method from parent class ComputeDriver.py was invoked during instance polling task which throws NotImplementedError. Hence we are seeing a warning message per every minute in nova-compute logs. The warning message looks like, "2011-04-13 13:54:34,203 WARNING nova.compute.manager [-] Error during instance poll:"
"

Revision history for this message

Matt Dietz (cerberus) wrote on 2011-04-19:

Question:

24-36: Is there ever a case where either vm_state or conn_state wouldn't be set?

Nits:

+ LOG.debug(_("Getting details of available instances ."))

Remove the space between 'instances' and the period

Otherwise seems good

review: Needs Fixing

Revision history for this message

Devin Carlen (devcamcar) wrote on 2011-05-13:

Setting to work in progress since there have been outstanding questions against this proposal for almost 4 weeks.

Unmerged revisions

988. By Sateesh on 2011-04-14

Implemented method "list_instances_detail" in VMWareVMOps class. This will be called from compute/manager.py as part of instance polling task.

Earlier the method from parent class ComputeDriver.py was invoked during instance polling task which throws NotImplementedError. Hence we are seeing a warning message per every minute in nova-compute logs. The message looks like "2011-04-13 13:54:34,203 WARNING nova.compute.manager [-] Error during instance poll:
"