unity-2d

Code review comment for lp://qastaging/~saviq/unity-2d/unmaximize-on-drag

  1. unmaximize-on-drag
  2. Merge into natty
Revision history for this message
Ugo Riboni (uriboni) wrote :

124 + case QEvent::MouseButtonDblClick:
125 + QMetaObject::invokeMethod(m_widget, "menuBarDblClicked");

and

145 + QMetaObject::invokeMethod(m_widget, "menuBarDragged",
146 + Q_ARG(QPoint*, &m_dragStartPosition));

Is there any particular reason why you used invokeMethod instead of using qobject_cast<MenuBarWidget*>(m_widget) and they if the cast succeeded just call the method directly ?

review: Needs Information

« Back to merge proposal