Code review comment for lp://qastaging/~sergei.glushchenko/percona-xtrabackup/xb-tools

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

> Couple more comments:
>
> The page printer utility starts & commits MTRs, for example i
> ib_page_load_table_for_id(). How does that work since we are not allowed to
> write to the log in the utility?
>

As long as page printer doesn't make changes to buffer pool pages, mtr_commit doesn't write to log.

> How do you plan automating testing this, both as standalone utility and GDB
> entry points in the XB binary?

We should think about it:)

« Back to merge proposal