eCryptfs

Merge lp://qastaging/~sergio-pena/ecryptfs/917509 into lp://qastaging/~ecryptfs/ecryptfs/oldtrunk2

917509
Merge into oldtrunk2

Proposed by Sergio Peña on 2012-04-26

Status:	Merged
Merged at revision:	685
Proposed branch:	lp://qastaging/~sergio-pena/ecryptfs/917509
Merge into:	lp://qastaging/~ecryptfs/ecryptfs/oldtrunk2
Diff against target:	311 lines (+85/-166) 3 files modified src/include/ecryptfs.h (+0/-1) src/libecryptfs/main.c (+0/-100) src/utils/mount.ecryptfs.c (+85/-65)
To merge this branch:	bzr merge lp://qastaging/~sergio-pena/ecryptfs/917509
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Dustin Kirkland 		Needs Fixing on 2012-04-26
Tyler Hicks	2012-04-26	Needs Fixing on 2012-04-26
Review via email: mp+103779@code.qastaging.launchpad.net

Description of the change

Here's the code with the use of execl() to mount eCryptfs.

I edited the last proposal after comments from Tyler.

I tested this on Ubuntu Precise and Centos 6.2.
The test included the use of /etc/fstab with noatime,noauto flags. Also I did the mount manually with noauto,noatime options and others ecryptfs options.

Revision history for this message

Tyler Hicks (tyhicks) wrote on 2012-04-26:

Thanks, Sergio! One last change needs to made. Check the man page of waitpid() and note that WEXITSTATUS() should only be used if WIFEXITED() is true.

review: Needs Fixing

Revision history for this message

Dustin Kirkland  (kirkland) wrote on 2012-04-26:

Sergio,

- Also, check the indentation of your new ecryptfs_mount(), which is inconsistent with the rest of that file.
- "if (strlen(opts) > 200) {" ... can we use a suitable constant here instead of an arbitrary "200"?
- num_opts can go away, as that variable is no longer used, as can flags, in ecryptfs_do_mount()

:-Dustin

review: Needs Fixing

lp://qastaging/~sergio-pena/ecryptfs/917509 updated on 2012-04-27