Code review comment for lp://qastaging/~sergio-pena/ecryptfs/917509

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Sergio,

 - Also, check the indentation of your new ecryptfs_mount(), which is inconsistent with the rest of that file.
 - "if (strlen(opts) > 200) {" ... can we use a suitable constant here instead of an arbitrary "200"?
 - num_opts can go away, as that variable is no longer used, as can flags, in ecryptfs_do_mount()

:-Dustin

review: Needs Fixing

« Back to merge proposal