Snapcraft

Merge lp://qastaging/~sergiusens/snapcraft/lifecycle into lp://qastaging/~snappy-dev/snapcraft/core

  1. lifecycle
  2. Merge into core
Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 213
Merged at revision: 248
Proposed branch: lp://qastaging/~sergiusens/snapcraft/lifecycle
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 191 lines (+28/-28)
4 files modified
snapcraft/cmds.py (+3/-3)
snapcraft/tests/test_lifecycle.py (+21/-22)
snapcraft/tests/test_yaml.py (+1/-1)
snapcraft/yaml.py (+3/-2)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/lifecycle
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Review via email: mp+274947@code.qastaging.launchpad.net

Commit message

Rename snapcraft.plugin to snapcraft.lifecycle

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

I like the new name.
I left a question on the diff, but not a blocker. +1.

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Mon, Oct 19, 2015 at 7:50 PM, Leo Arias <email address hidden> wrote:

> Review: Approve
>
> I like the new name.
> I left a question on the diff, but not a blocker. +1.
>
> Diff comments:
>
> > -from snapcraft import (
> > - plugin,
> > - tests
> > -)
> > +import snapcraft.lifecycle
> > +import snapcraft.tests
>
> any reason for this change?
> when I started using more than one level in the namespace some python
> people started saying I was doing it like java.
>
>
Because you told me you preferred it ;-)

Revision history for this message
Leo Arias (elopio) wrote :

um, I don't think so, but maybe you are right and I said something like that. Anyway, what I usually say is that I prefer to import modules than symbols. Like

from snapcraft import lifecycle

instead of

from snapcraft.lifecycle import load_plugin.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches