Code review comment for lp://qastaging/~sergiusens/snapcraft/lifecycle
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
On Mon, Oct 19, 2015 at 7:50 PM, Leo Arias <email address hidden> wrote:
> Review: Approve
>
> I like the new name.
> I left a question on the diff, but not a blocker. +1.
>
> Diff comments:
>
> > -from snapcraft import (
> > - plugin,
> > - tests
> > -)
> > +import snapcraft.lifecycle
> > +import snapcraft.tests
>
> any reason for this change?
> when I started using more than one level in the namespace some python
> people started saying I was doing it like java.
>
>
Because you told me you preferred it ;-)