Merge lp://qastaging/~sergiusens/snapcraft/localplugs-- into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
Status: | Merged |
---|---|
Approved by: | Sergio Schvezov |
Approved revision: | 193 |
Merged at revision: | 193 |
Proposed branch: | lp://qastaging/~sergiusens/snapcraft/localplugs-- |
Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
Prerequisite: | lp://qastaging/~sergiusens/snapcraft/module_name |
Diff against target: |
92 lines (+15/-33) 2 files modified
snapcraft/plugin.py (+15/-19) snapcraft/tests/test_plugin.py (+0/-14) |
To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/localplugs-- |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Schvezov | Approve | ||
Leo Arias (community) | Approve | ||
Review via email: mp+271907@code.qastaging.launchpad.net |
Commit message
Local plugins as fallback instead of special casing to follow the spec
To post a comment you must log in.
+def local_plugindir():
this is only used in the plugin.py file, so you can use this opportunity to make it internal: _local_plugindir.
Approve anyway as it's not a blocker.