Merge lp://qastaging/~shanepatrickfagan/unity/unity-replace into lp://qastaging/unity

Proposed by Shane Fagan
Status: Merged
Merged at revision: 735
Proposed branch: lp://qastaging/~shanepatrickfagan/unity/unity-replace
Merge into: lp://qastaging/unity
Diff against target: 21 lines (+5/-1)
1 file modified
tools/unity.cmake (+5/-1)
To merge this branch: bzr merge lp://qastaging/~shanepatrickfagan/unity/unity-replace
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Jason Smith (community) Approve
Review via email: mp+44301@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :

+1 helps users used to gnome-shell --replace

review: Approve
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hi Fagan, thanks for the merge request and your work there.

I definitively see the added value of such an option to users. However, I think that we should make it clear that the design decision is to make it useless. This should be noted in the Help of the switch (maybe even adding an "compatibility" option group) and print a warning when using it telling it's useless.

review: Needs Fixing
Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :

> Hi Fagan, thanks for the merge request and your work there.
>
> I definitively see the added value of such an option to users. However, I
> think that we should make it clear that the design decision is to make it
> useless. This should be noted in the Help of the switch (maybe even adding an
> "compatibility" option group) and print a warning when using it telling it's
> useless.

Cool ill fix that give me 10 minutes and ill add the text.

Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :

Ok pushed it should be a little bit more descriptive now

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks for that fagan, can you also achieve the second part of my request: "print a warning when using it telling it's useless."

Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :

I thought my change did that, what wording would you want instead?

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Sorry, I'm maybe not clear. I meant "when you run unity --replace" print the warning as well.

Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :

Oh ok then ill upload a merge in 10 minutes

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks fagan, I'll add a commit to replace Unity by unity in the warning as you are talking about the command line and not the shell :)

Merging it now, thanks for your work there!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.