Code review comment for lp://qastaging/~sil/desktopcouch/allow-unpairing
Revision history for this message
| Stuart Langridge (sil) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> The FIXME and "does not work" in the commit messages make me a little charry.
> What behavior are we supposed to expect from this branch, and why are we
> merging it to trunk if we don't want to ship it?
It's being merged to trunk because we need to do some work based on it being done. Keeping this out of trunk and doing the further work based on this branch and then merging the lot makes for a mammoth merge in the future, and doing it in bite-size chunks makes review easier. The "does not work" stuff is because the code now knows how to receive oauth data from a remote desktopcouch, but remote desktopcouches don't send that data (this is the future work to be done). So the code itself works if handed correct data, but the overall approach (actually making local desktopcouches pair) does not (because it is not handed corrrect data).