Code review comment for lp://qastaging/~sil/desktopcouch/dc-load-design-docs

Revision history for this message
Eric Casteleijn (thisfred) wrote :

I'm getting this again (and seem to be the only one) but it's easily fixed by not using twistedtestcase, which I don't think we need in any case.

===============================================================================
[ERROR]: desktopcouch.tests.test_start_local_couchdb.TestUpdateDesignDocuments.test_create_databases_and_design_docs

Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 155909676 [29.9993708134s] called=0 cancelled=0 Client.failIfNotConnected(TimeoutError('',))>
<DelayedCall 155910124 [19.5468599796s] called=0 cancelled=0 exit_on_timeout()>
<DelayedCall 157621132 [59.999724865s] called=0 cancelled=0 ThreadedResolver._cleanup(u'thelog.local', <Deferred at 0x9651b4c>)>
===============================================================================
[ERROR]: desktopcouch.tests.test_start_local_couchdb.TestUpdateDesignDocuments.test_create_databases_and_design_docs

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 106, in maybeDeferred
    result = f(*args, **kw)
  File "/home/eric/canonical/desktopcouch/r-sil/desktopcouch/pair/tests/test_network_io.py", line 90, in exit_on_success
    reactor.stop()
  File "/usr/lib/python2.6/dist-packages/twisted/trial/unittest.py", line 953, in _
    return self._reactorMethods[name](*a, **kw)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line 527, in stop
    "Can't stop reactor that isn't running.")
twisted.internet.error.ReactorNotRunning: Can't stop reactor that isn't running.
-------------------------------------------------------------------------------

review: Needs Fixing

« Back to merge proposal