Code review comment for lp://qastaging/~sil/desktopcouch/viewparams-497143

Revision history for this message
Stuart Langridge (sil) wrote :

The reason I don't just pass all unknown parameters directly to the underlying view, and instead require a dict of parameters, is in case we decide to add additional things to that function later. If Eric and Chad think it should be changed then I'll change it.

Has this branch introduced a dependency on the keyring? If not, then it'll be better to approve this and then fix the problem in another branch.

« Back to merge proposal