Code review comment for lp://qastaging/~sil2100/compiz/compiz_abi_bump

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

bzr status -rv0.9.8.2..v0.9.8.4
shows that no core headers, and hence the core ABI, has not changed. Although didrocks incremented the ABI between 0.9.8.2 and 0.9.8.4 already. I'm not sure why.

So it seems the core ABI has already been changed more than it should recently. It should not change again unless the actual ABI changes. That means the size of a class or virtual methods change in one of the public core headers. I haven't seen any such changes that affect the ABI for a while.

review: Disapprove

« Back to merge proposal