Code review comment for lp://qastaging/~sinabakh/ubuntu-calculator-app/history-using-arrow-keys

Revision history for this message
Sina Bakhtiari (sinabakh) wrote :

> Thanks. Nice improvement.
>
> Unfortunately it is causing lost of last typed formula.
> Steps to reproduce:
> 1. Create several entries in calculation history
> 2. Type some formula: 25*25
> 2. Press up key (the previous calculation will appear)
> 3. Press down key
>
> Currently:
> - Empty formula is shown
>
> Expected:
> - 25*25 should be shown

Yes, currently it just uses the history of calculated formulas not the one which is being written. I will try to fix it.
Thanks for pointing it out.

« Back to merge proposal