Code review comment for lp://qastaging/~sinabakh/ubuntu-calculator-app/history-using-arrow-keys

I have submitted ticket for left and right cursor:
https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1610207

> The first problem that you mentioned is fixed.
> Regarding the 2 next points you made:
>
> > Also I would expect that if any other than "up" and "down" key were pressed,
> > then the formula selection were reset (it is starting from bottom).

Let's leave it as it is already implemented, and get UX feedback

> I think it might be better not to implement this, because there are cases
> where people want to access a formula in the history but edit parts of it. In
> that case they will use left/right keys to change the position of the cursor
> and other keys to edit the formula.
>
> > It will be also great to show some indicator what is currently selected
> > formula.
> > It could be in form of background color.
>
> Wouldn't it be better to implement this features in different branch ? I mean
> registering a different Bug and implement it independent of this history
> related branch. Because it have things more related to UI than the history
> logics.

I don't think this work could be separated, as it is stricly connected with "up and down" feature. Without indicator of currently selected calculation from history, it gives bad User Excperience.
For example user could press accidently "up" key, and the whole formula which was typed will gone. With indicator it will be visible that formula was changed with calculation from the history.

It will be also great to implement "Escape" press. If you press Escape key, then it exit from history preview and go back to the old formula.

What do you think about that?