Code review comment for lp://qastaging/~sinabakh/ubuntu-calculator-app/history-using-arrow-keys

Revision history for this message
Sina Bakhtiari (sinabakh) wrote :

> Let's leave it as it is already implemented, and get UX feedback
>
Sure, thanks!

>
> I don't think this work could be separated, as it is stricly connected with
> "up and down" feature. Without indicator of currently selected calculation
> from history, it gives bad User Excperience.
> For example user could press accidently "up" key, and the whole formula which
> was typed will gone. With indicator it will be visible that formula was
> changed with calculation from the history.

Yes, you are completely right.
Just a question, in you opinion, when user is browsing history and starts to edit one of past formulas, is it better to reset the history and take the edited formula as the current formula, or no, save the current state of history and do not overwrite the last formula (like what happens in terminal) ?

> It will be also great to implement "Escape" press. If you press Escape key,
> then it exit from history preview and go back to the old formula.
>
> What do you think about that?
I like the idea, it will be implemented.

P.S: Is there a place (IRC or mailing list) where I can reach you or other calculator developers in case that I have development questions?

Regards

« Back to merge proposal