I have no reason to believe it is doing the wrong thing, but expressions like the following don't parse easily:
2706 + return CompRect (geometry ().xMinusBorder () - priv->border.left, 2707 + geometry ().yMinusBorder () - priv->border.top,
why are we subtracting a border from "*MinusBorder"? why isn't that what "MinusBorder" does?
2708 + geometry ().widthIncBorders () + 2709 priv->border.left + priv->border.right, 2711 + geometry ().heightIncBorders () + 2712 priv->border.top + priv->border.bottom);
why are we adding borders to "*IncBorders"? why isn't that what "IncBorders" does?
(I suspect it's a naming thing, or a missing abstraction.)
« Back to merge proposal
I have no reason to believe it is doing the wrong thing, but expressions like the following don't parse easily:
2706 + return CompRect (geometry ().xMinusBorder () - priv->border.left,
2707 + geometry ().yMinusBorder () - priv->border.top,
why are we subtracting a border from "*MinusBorder"? why isn't that what "MinusBorder" does?
2708 + geometry ().widthIncBorders () + bottom) ;
2709 priv->border.left + priv->border.right,
2711 + geometry ().heightIncBorders () +
2712 priv->border.top + priv->border.
why are we adding borders to "*IncBorders"? why isn't that what "IncBorders" does?
(I suspect it's a naming thing, or a missing abstraction.)