Code review comment for lp://qastaging/~smspillaz/unity/unity.extract_switcher_interface

Revision history for this message
Andrea Azzarone (azzar1) wrote :

84 + virtual void Show(ShowMode show, SortMode sort, std::vector<launcher::AbstractLauncherIcon::Ptr> results);
85 + virtual void Hide(bool accept_state=true);

We use gcc 4.7 so we can use override keyword ;)

+#include <time.h>

Not sure this is really needed.

=== added file 'tests/MockWindowManager.h'

???

Also some code does not use unity-stile and I don't like the abuse of impl keyword in:

impl::SwitcherViewImpl::Ptr(new impl::SwitcherViewImpl());

I just prefer to have SwitcherView for the interface and SwitcherViewImpl for the implementation but it's not a problem :)

review: Approve

« Back to merge proposal