Code review comment for lp://qastaging/~smspillaz/unity/unity.extract_switcher_interface

> 84 + virtual void Show(ShowMode show, SortMode sort,
> std::vector<launcher::AbstractLauncherIcon::Ptr> results);
> 85 + virtual void Hide(bool accept_state=true);
>
> We use gcc 4.7 so we can use override keyword ;)
>
> +#include <time.h>
>
> Not sure this is really needed.

I'll get rid of it

>
>
> === added file 'tests/MockWindowManager.h'
>
> ???

Should be fixed by a trunk merge, thanks.

>
>
> Also some code does not use unity-stile and I don't like the abuse of impl
> keyword in:
>
> impl::SwitcherViewImpl::Ptr(new impl::SwitcherViewImpl());
>
> I just prefer to have SwitcherView for the interface and SwitcherViewImpl for
> the implementation but it's not a problem :)

I'll see if there's a way we can make it back into SwitcherView (for the interface)