Merge lp://qastaging/~smspillaz/unity/unity.fix_943456 into lp://qastaging/unity
Proposed by
Sam Spilsbury
Status: | Merged |
---|---|
Approved by: | Tim Penhey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2049 |
Proposed branch: | lp://qastaging/~smspillaz/unity/unity.fix_943456 |
Merge into: | lp://qastaging/unity |
Diff against target: |
189 lines (+30/-18) 1 file modified
plugins/unityshell/src/unityshell.cpp (+30/-18) |
To merge this branch: | bzr merge lp://qastaging/~smspillaz/unity/unity.fix_943456 |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Neil J. Patel (community) | Needs Fixing | ||
Gord Allott (community) | Needs Fixing | ||
Sam Spilsbury (community) | Approve | ||
Daniel van Vugt | Approve | ||
Review via email:
|
Commit message
Fix the Alt+F1 or Alt+F2 sending a ";3P" or ";3Q" to the active windows issue, and also fixes some alt holding showing menus. Compiz-core fix needed for complete fix.
Description of the change
== Problem Desc ==
Pressing unity keybindings would result in those keys being replayed in application
== Fix ==
Return true in the action handlers, telling compiz that we actually handled the keys
== Test Coverage ==
Existing key press and key release manual tests / AP tests
UNBLOCK
To post a comment you must log in.
This is the same as my fix, which I was about to propose. Except that this one fixes many more key combos. Not just Alt+F1/Alt+F2.