Code review comment for lp://qastaging/~smspillaz/unity/unity.fix_943456

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

> Somehow seems to cause an issue when re-focusing a terminal/sometimes other
> windows - the terminal gets pushed to an edge, either top or bottom in my
> experience, confirmed through neil also if you need testers/can't reproduce.
>
> A bit of debugging i noticed that if i removed the
> PluginAdapter::restoreInputFocus() call from HUDs hide method the issue no
> longer happens. of course the previously focused window no longer recieves
> focus when the hud closes if this method is removed.

This isn't an issue with this branch in particular, but with some other part of the focus code, so it needs to be fixed separately.

« Back to merge proposal