Juju Charms Collection
nova-compute package

Code review comment for lp://qastaging/~springfield-team/charms/trusty/nova-compute/n1kv

  1. Trusty Tahr (14.04)
  2. n1kv
  3. Merge into next
Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Hello,

Please fix the following 'make lint' errors:

hooks/nova_compute_context.py:322:17: E126 continuation line over-indented for hanging indent
hooks/nova_compute_context.py:324:17: E126 continuation line over-indented for hanging indent
hooks/nova_compute_context.py:326:17: E126 continuation line over-indented for hanging indent
hooks/nova_compute_utils.py:176:80: E501 line too long (86 > 79 characters)
hooks/nova_compute_utils.py:177:80: E501 line too long (107 > 79 characters)
hooks/nova_compute_utils.py:474:80: E501 line too long (96 > 79 characters)
unit_tests/test_nova_compute_utils.py:372:80: E501 line too long (90 > 79 characters)
unit_tests/test_nova_compute_utils.py:378:80: E501 line too long (111 > 79 characters)
unit_tests/test_nova_compute_utils.py:382:80: E501 line too long (93 > 79 characters)

Also , Please remove the commented modules from tests, if you aren't using them.

After having this fixed, LGTM.

review: Needs Fixing

« Back to merge proposal