Code review comment for lp://qastaging/~springfield-team/charms/trusty/vem/next

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Hello,

Thanks for your submission. Please don't ignore E401 and E501 errors from flake8.

Please add something like this, on your Makefile:

flake8 --exclude hooks/charmhelpers --ignore=E125,F401 hooks/

Please fix the following lint errors:

hooks/common.py:4:12: E401 multiple imports on one line
hooks/common.py:5:12: E401 multiple imports on one line
hooks/common.py:150:80: E501 line too long (103 > 79 characters)
hooks/common.py:151:80: E501 line too long (131 > 79 characters)
hooks/common.py:152:80: E501 line too long (115 > 79 characters)
hooks/common.py:153:80: E501 line too long (115 > 79 characters)
hooks/common.py:154:80: E501 line too long (103 > 79 characters)
hooks/common.py:155:80: E501 line too long (95 > 79 characters)
hooks/common.py:156:80: E501 line too long (135 > 79 characters)
hooks/common.py:172:80: E501 line too long (95 > 79 characters)
hooks/common.py:173:80: E501 line too long (134 > 79 characters)
hooks/common.py:174:80: E501 line too long (84 > 79 characters)
hooks/common.py:175:80: E501 line too long (98 > 79 characters)
hooks/common.py:176:80: E501 line too long (85 > 79 characters)
hooks/common.py:178:80: E501 line too long (130 > 79 characters)
hooks/common.py:206:80: E501 line too long (80 > 79 characters)
hooks/common.py:251:80: E501 line too long (82 > 79 characters)
hooks/common.py:282:80: E501 line too long (80 > 79 characters)
hooks/config_changed.py:2:80: E501 line too long (81 > 79 characters)
hooks/config_changed.py:19:80: E501 line too long (156 > 79 characters)
hooks/config_changed.py:24:80: E501 line too long (81 > 79 characters)
hooks/config_changed.py:25:80: E501 line too long (95 > 79 characters)
hooks/config_changed.py:26:80: E501 line too long (83 > 79 characters)
hooks/config_changed.py:27:80: E501 line too long (83 > 79 characters)
hooks/config_changed.py:29:80: E501 line too long (93 > 79 characters)
hooks/config_changed.py:31:80: E501 line too long (81 > 79 characters)
hooks/config_changed.py:38:80: E501 line too long (252 > 79 characters)
hooks/install.py:3:80: E501 line too long (81 > 79 characters)
hooks/install.py:7:14: E401 multiple imports on one line
hooks/install.py:41:80: E501 line too long (124 > 79 characters)
hooks/install.py:42:80: E501 line too long (113 > 79 characters)
hooks/install.py:64:80: E501 line too long (92 > 79 characters)
hooks/install.py:65:80: E501 line too long (88 > 79 characters)
hooks/install.py:66:80: E501 line too long (90 > 79 characters)
hooks/install.py:68:80: E501 line too long (88 > 79 characters)

Also, please review the inline comments.

review: Needs Fixing

« Back to merge proposal