Code review comment for lp://qastaging/~springfield-team/charms/trusty/vem/next

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Please remove the file 'data.yaml.orig' from the charm's root.

Please clarify me, Why those 'relation_get', 'config_get', 'juju_log' methods on hooks/common.py are required?

All those functions are available on the charmhelpers library, Why are you copying this into a different file?

review: Needs Fixing

« Back to merge proposal