Juju Charms Collection
vem package

Code review comment for lp://qastaging/~springfield-team/charms/trusty/vem/next

  1. Trusty Tahr (14.04)
  2. next
  3. Merge into trunk
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM, however it took quite a while to get the test running because of little or no documentation on how to run the tests. Adding this information to the README would be crucial in the next merge request. Furthermore, the Makefile has several dead targets (build, sync-charm-helpers) which should be removed.

LGTM otherwise.

review: Approve

« Back to merge proposal