Code review comment for lp://qastaging/~stewart/drizzle/bug702502-part1

Revision history for this message
David Shrewsbury (dshrews) wrote :

The proto definition is a bit confusing... why aren't RENAME and ALTER KEYS listed under the Operation enum and are in their own sub-messages instead?

It doesn't seem that there is a neat/compact/easy way to determine all of the operations that a message is trying to do. It looks like in order to do this, we'd have to call has_rename(), has_alter_keys_onoff(), AND loop through the Operations list. Is that going to get more complex as we add the rest of the possible operations?

« Back to merge proposal