phablet-extras

Merge lp://qastaging/~stolowski/phablet-extras/unity-lens-mock-new-api into lp://qastaging/phablet-extras/unity-lens-mock

  1. unity-lens-mock-new-api
  2. Merge into unity-lens-mock
Proposed by Paweł Stołowski
Status: Superseded
Proposed branch: lp://qastaging/~stolowski/phablet-extras/unity-lens-mock-new-api
Merge into: lp://qastaging/phablet-extras/unity-lens-mock
Diff against target: 325 lines (+18/-63)
4 files modified
debian/changelog (+6/-0)
debian/control (+1/-0)
unity-lens-mock (+11/-10)
unity_lens_mock/scope.py (+0/-53)
To merge this branch: bzr merge lp://qastaging/~stolowski/phablet-extras/unity-lens-mock-new-api
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Review via email: mp+167721@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2013-06-19.

Commit message

Updated for new scopes API.

Description of the change

Updated for new scopes API.

Please have a look at https://code.launchpad.net/~stolowski/unity/phablet-new-libunity/+merge/167717 before approving.

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

This should depend on unity-scopes-runner, probably?

review: Needs Fixing
lp://qastaging/~stolowski/phablet-extras/unity-lens-mock-new-api updated
16. By Paweł Stołowski

Require unity-scopes-runner.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

> This should depend on unity-scopes-runner, probably?
Right, done.

Revision history for this message
Michał Sawicz (saviq) wrote :

This looks good, before top-approving, will verify again with:

https://code.launchpad.net/~unity-team/unity/8.new-libunity/+merge/167733
https://code.launchpad.net/~stolowski/demo-assets/new-api/+merge/167718

review: Approve

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches