phablet-extras

Merge lp://qastaging/~unity-team/phablet-extras/unity-lens-mock-new-api into lp://qastaging/phablet-extras/unity-lens-mock

  1. unity-lens-mock-new-api
  2. Merge into unity-lens-mock
Proposed by Michał Sawicz
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 18
Merged at revision: 14
Proposed branch: lp://qastaging/~unity-team/phablet-extras/unity-lens-mock-new-api
Merge into: lp://qastaging/phablet-extras/unity-lens-mock
Diff against target: 357 lines (+8/-116)
5 files modified
debian/changelog (+7/-0)
debian/control (+1/-0)
setup.py (+0/-1)
unity-lens-mock (+0/-62)
unity_lens_mock/scope.py (+0/-53)
To merge this branch: bzr merge lp://qastaging/~unity-team/phablet-extras/unity-lens-mock-new-api
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+170441@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-06-06.

Commit message

Updated for smart scopes API.

Description of the change

Updated for new scopes API.

Please have a look at https://code.launchpad.net/~stolowski/unity/phablet-new-libunity/+merge/167717 before approving.

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

This should depend on unity-scopes-runner, probably?

review: Needs Fixing
Revision history for this message
Paweł Stołowski (stolowski) wrote : Posted in a previous version of this proposal

> This should depend on unity-scopes-runner, probably?
Right, done.

Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

This looks good, before top-approving, will verify again with:

https://code.launchpad.net/~unity-team/unity/8.new-libunity/+merge/167733
https://code.launchpad.net/~stolowski/demo-assets/new-api/+merge/167718

review: Approve
lp://qastaging/~unity-team/phablet-extras/unity-lens-mock-new-api updated
18. By Michał Sawicz

Release for saucy.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:18
http://jenkins.qa.ubuntu.com/job/phablet-extras-unity-lens-mock-ci/1/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-unity-lens-mock-saucy-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/phablet-extras-unity-lens-mock-saucy-armhf-ci/1/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-unity-lens-mock-saucy-i386-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-extras-unity-lens-mock-ci/1/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Good.

review: Approve
Revision history for this message
Michał Sawicz (saviq) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches