Unity Home Scope

Merge lp://qastaging/~stolowski/unity-scope-home/preview-click-events into lp://qastaging/unity-scope-home

preview-click-events
Merge into trunk

Proposed by Paweł Stołowski on 2013-10-25

Status:

Merged

Approved by:

Michal Hruby on 2013-10-25

Approved revision:

181

Merged at revision:

177

Proposed branch:

lp://qastaging/~stolowski/unity-scope-home/preview-click-events

Merge into:

lp://qastaging/unity-scope-home

Diff against target:

294 lines (+137/-9)

9 files modified

configure.ac (+2/-2)
debian/control (+1/-1)
src/scope.vala (+14/-3)
src/smart-scopes-interface.vala (+2/-0)
src/smart-scopes-metrics.vala (+3/-0)
src/smart-scopes-preview-parser.vala (+6/-1)
src/smart-scopes-search.vala (+3/-0)
tests/unit/test-home-scope.vala (+63/-2)
tests/unit/test-utils.vala (+43/-0)

To merge this branch:

bzr merge lp://qastaging/~stolowski/unity-scope-home/preview-click-events

High

Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michal Hruby (community)		2013-10-25	Approve on 2013-10-25
PS Jenkins bot (community)	continuous-integration		Approve on 2013-10-25
Review via email: mp+192668@code.qastaging.launchpad.net

Commit message

Collect click metrics for preview actions.

Description of the change

Collect click metrics for preview actions. Requires latest libunity 7.1.3.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-10-25:

PASSED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/104/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-trusty-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-trusty-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-trusty-i386-ci/1

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-scope-home-ci/104/rebuild

review: Approve (continuous-integration)

Revision history for this message

Michal Hruby (mhr3) wrote on 2013-10-25:

Looks alright, but...

183 + // FIXME: I wish there was a better way of doing this... small delay to give fake server a chance to write metrics
184 + Posix.sleep (2);
190 + var stream = FileStream.open (FEEDBACK_FILE, "r");

... relying on a different process to write a file, sleeping and reading the file later is a recipe for testing disaster. Let's get rid of that and instead check that the metrics event was submitted - that way it'll be kept local to the process. After all we're not testing the fake server's capability to write files.

review: Needs Fixing

lp://qastaging/~stolowski/unity-scope-home/preview-click-events updated on 2013-10-25