183 + // FIXME: I wish there was a better way of doing this... small delay to give fake server a chance to write metrics
184 + Posix.sleep (2);
190 + var stream = FileStream.open (FEEDBACK_FILE, "r");
... relying on a different process to write a file, sleeping and reading the file later is a recipe for testing disaster. Let's get rid of that and instead check that the metrics event was submitted - that way it'll be kept local to the process. After all we're not testing the fake server's capability to write files.
Looks alright, but...
183 + // FIXME: I wish there was a better way of doing this... small delay to give fake server a chance to write metrics
184 + Posix.sleep (2);
190 + var stream = FileStream.open (FEEDBACK_FILE, "r");
... relying on a different process to write a file, sleeping and reading the file later is a recipe for testing disaster. Let's get rid of that and instead check that the metrics event was submitted - that way it'll be kept local to the process. After all we're not testing the fake server's capability to write files.