Code review comment for lp://qastaging/~stub/charm-helpers/bug-1195649-fix-write-file

Revision history for this message
Stuart Bishop (stub) wrote :

I've moved the helper to contrib.

I removed render_template_file() entirely for now. Perhaps write_file should do implicit rendering of usernames, groupnames & paths? It is magic, but at least with python formatting using curly brackets it is safe(ish) magic in these cases.

« Back to merge proposal