Unity Home Scope

Merge lp://qastaging/~submarine/unity-scope-home/dedup-sort-misc into lp://qastaging/unity-scope-home

dedup-sort-misc
Merge into trunk

Proposed by David Callé on 2013-05-13

Status:	Merged
Approved by:	Paweł Stołowski on 2013-05-13
Approved revision:	114
Merged at revision:	113
Proposed branch:	lp://qastaging/~submarine/unity-scope-home/dedup-sort-misc
Merge into:	lp://qastaging/unity-scope-home
Diff against target:	13 lines (+2/-2) 1 file modified src/master-scopes.vala (+2/-2)
To merge this branch:	bzr merge lp://qastaging/~submarine/unity-scope-home/dedup-sort-misc
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Paweł Stołowski (community)		2013-05-13	Approve on 2013-05-13
PS Jenkins bot (community)	continuous-integration		Approve on 2013-05-13
Review via email: mp+163500@code.qastaging.launchpad.net

Commit message

Change some dedup and sort fields (boxes, web, code, help, graphics)

Description of the change

This branch introduces a few changes in master sorting and deduplication :

Boxes : sort all by title
Better merging of sources (ssh, virtualbox)

Web : sort bookmarks by title
Eases bookmarks browsing

Code : sort code and people by title
Better merging of GitHub and Launchpad results

Help : dedup all by title
Eases browsing, (eg avoid duplicates between stackexchange and askubuntu, deduplicates local help results for people with multiple locales installed)

Graphics : sort all by title
Better merging of sources

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-05-13:

PASSED: Continuous integration, rev:113
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/35/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-raring-amd64-ci/37

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/35/rebuild

review: Approve (continuous-integration)

Revision history for this message

Paweł Stołowski (stolowski) wrote on 2013-05-13:

I'm reluctant to approve sort-by-title changes for the reasons we discussed via IRC, so to summarize:
- with 2 bookmarks: "wikipedia" and "Ubuntu wiki", searching for "wik" gives "Ubuntu wiki" and "wikipedia".
- currently, results in home scope are displayed in the order of their arrival and aren't updated when master re-orders them, which ensures there is no flickering and reordering inside categories. I'm not sure we should change it.

I'd suggest we only apply dedup_field rules and abandon sort_filed changes for now.

review: Needs Fixing

lp://qastaging/~submarine/unity-scope-home/dedup-sort-misc updated on 2013-05-13