Code review comment for lp://qastaging/~submarine/unity-scope-home/dedup-sort-misc

Revision history for this message
Paweł Stołowski (stolowski) wrote :

I'm reluctant to approve sort-by-title changes for the reasons we discussed via IRC, so to summarize:
- with 2 bookmarks: "wikipedia" and "Ubuntu wiki", searching for "wik" gives "Ubuntu wiki" and "wikipedia".
- currently, results in home scope are displayed in the order of their arrival and aren't updated when master re-orders them, which ensures there is no flickering and reordering inside categories. I'm not sure we should change it.

I'd suggest we only apply dedup_field rules and abandon sort_filed changes for now.

review: Needs Fixing

« Back to merge proposal