Code review comment for lp://qastaging/~suutari-olli/openlp/combined-bible-quick-search

Revision history for this message
Azaziah (suutari-olli) wrote :

I fixed most of these things and replied to the comments.
Now re-proposing. (Still need some tests though)

------------------

Comments in line.
Mainly style and missing bits like comments.

Some tests will be needed.

Some of the comments are based on moved code but it was wrong then and can be made better.

Left you a challenge at the end.

« Back to merge proposal