Code review comment for lp://qastaging/~suutari-olli/openlp/combined-bible-quick-search

Revision history for this message
Azaziah (suutari-olli) wrote :

> Not convinced with the timer. This needs thinking about.
> A singleshot will only fire once.

What do you mean "A singleshot will only fire once."?

singleshot resets timer to 0 every time a char is added or removed.
If this timer reaches 1.2 seconds, search is performed.

Timer is a must, OpenLP can't handle the fully automatic Bible text search without it.

If timer is not used, typing few chars into text search will break OpenLP
since every char triggers a new search.

Some other timer methods result in infinite loops and crash OpenLP.

« Back to merge proposal