Merge lp://qastaging/~sylvain-pineau/checkbox/camera_test_cheese_introspection into lp://qastaging/checkbox

Proposed by Sylvain Pineau
Status: Superseded
Proposed branch: lp://qastaging/~sylvain-pineau/checkbox/camera_test_cheese_introspection
Merge into: lp://qastaging/checkbox
Prerequisite: lp://qastaging/~sylvain-pineau/checkbox/ppa-packaging-plainbox-provider-checkbox-fix-1568664
Diff against target: 233 lines (+90/-77)
2 files modified
providers/plainbox-provider-checkbox/bin/camera_test (+86/-77)
providers/plainbox-provider-checkbox/jobs/camera.txt.in (+4/-0)
To merge this branch: bzr merge lp://qastaging/~sylvain-pineau/checkbox/camera_test_cheese_introspection
Reviewer Review Type Date Requested Status
Taihsiang Ho Approve
Pierre Equoy Approve
Sylvain Pineau (community) Needs Resubmitting
Review via email: mp+291499@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2016-04-13.

Description of the change

This MR removes all gstreamer pipelines from the camera_test script. This new version relies on libcheese as creating a camera bin is not something we want to maintain in the checkbox provider.

WARNING:

DO not merge without the packaging branch update first.

To post a comment you must log in.
Revision history for this message
Taihsiang Ho (taihsiangho) wrote :

"./camera still"
works well on dino2 (CID 201508-18005) besides one small inline comment (please see below)

-------------

"./camera display"
crashed. The error message is:

http://paste.ubuntu.com/15760725/

./camera_test:570: PyGIWarning: Cheese was imported without specifying a version first. Use gi.require_version('Cheese', '3.0') before import to ensure that the right version gets loaded.
  from gi.repository import Cheese
Traceback (most recent call last):
  File "./camera_test", line 575, in <module>
    sys.exit(getattr(camera, args.test)())
  File "./camera_test", line 248, in display
    camera.set_device_by_device_node(self.args.device)
AttributeError: 'Camera' object has no attribute 'set_device_by_device_node'

review: Needs Fixing
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Thnaks for the review Tai. I made a few changes to support Xenial, resubmitting for review

review: Needs Resubmitting
Revision history for this message
Taihsiang Ho (taihsiangho) wrote :

on dino2 (CID 201508-18005)

* "./camera still" works well
* "./camera display" pops up a window and there is nothing (all white panel) in the window together with the following message in the console:

ubuntu@201508-18805:~/camera_test_cheese_introspection/providers/plainbox-provider-checkbox/bin$ ./camera_test display

(python3:2218): cheese-WARNING **: Internal GStreamer error: code not implemented. Please file a bug at http://bugzilla.gnome.org/enter_bug.cgi?product=GStreamer.: gstvideofilter.c(292): gst_video_filter_transform (): /GstCameraBin:camerabin/GstViewfinderBin:vf-bin/GstVideoConvert:vfbin-csp:
invalid video buffer received

(python3:2218): cheese-WARNING **: Internal GStreamer error: code not implemented. Please file a bug at http://bugzilla.gnome.org/enter_bug.cgi?product=GStreamer.: gstvideofilter.c(292): gst_video_filter_transform (): /GstCameraBin:camerabin/GstViewfinderBin:vf-bin/GstVideoConvert:vfbin-csp:
invalid video buffer received

Revision history for this message
Taihsiang Ho (taihsiangho) wrote :

test on another XPS (CID 201309-14238)

both of still and display works.

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Another xenial api change... the camera constructor expects a Clutter.Actor instead of a Clutter.Texture. I changed the code to handle both cases. Tested the daily build it works for me. Could you do another round with the dino hw please?

review: Needs Resubmitting
Revision history for this message
Pierre Equoy (pieq) wrote :

Tested successfully on:

- One Dino 2 device with Trusty
- One Dino 2 device with Xenial
- One Chiclet 15 device with Xenial

In all cases, I got the expected results for camera/detect, camera/still, camera/display and camera/multiple=resolution-images tests (from the Certification Test Plan).

review: Approve
Revision history for this message
Taihsiang Ho (taihsiangho) wrote :

more info:

my above test on a XPS (CID 201309-14238) was tested on Trusty. Sorry for unclear statement.

https://code.launchpad.net/~sylvain-pineau/checkbox/camera_test_cheese_introspection/+merge/291499/comments/747099

Revision history for this message
Taihsiang Ho (taihsiangho) wrote :

tested on a XPS (CID 201309-14238) with Xenial daily build (built on Apr. 7th)
both of camera still and display looks good.

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches