Code review comment for lp://qastaging/~ted/libindicator/service-management

On Wed, 2009-11-04 at 04:48 +0000, Ted Gould wrote:
>
> The problem is that if you use gtester with other tests then your
> reporting kinda sucks. If you use it through TESTS then you get the
> nice "1 of 3 failed" or some other information from autotest. If you
> want to use TESTS then they have to be shell scripts.

Do you mean 'If we have some gtester and some non-gtester tests' ?

I think the indirection through a shell script is much less clear than
runnning the test directly, and the gain (autotester knows how many
groups of tests are being run) is minimal. If you have multiple
directories with tests, or complex environments, then autotester loses
this data anyway. If we want consolidated reporting, generating subunit
logs and reporting from them is probably a lot saner.

For now I think its better to keep things as clear and shallow as
possible: as long as the test fails causes a build failure, thats the
key thing.

-Rob