Merge lp://qastaging/~ted/snapcraft/pkg-config-sysroot into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Ted Gould
Status: | Merged |
---|---|
Approved by: | Sergio Schvezov |
Approved revision: | 190 |
Merged at revision: | 205 |
Proposed branch: | lp://qastaging/~ted/snapcraft/pkg-config-sysroot |
Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
Diff against target: |
129 lines (+76/-4) 6 files modified
integration-tests/data/build-tools/Makefile (+6/-0) integration-tests/data/build-tools/icon.svg (+1/-0) integration-tests/data/build-tools/snapcraft.yaml (+14/-0) integration-tests/units/jobs.pxu (+12/-0) snapcraft/__init__.py (+7/-0) snapcraft/yaml.py (+36/-4) |
To merge this branch: | bzr merge lp://qastaging/~ted/snapcraft/pkg-config-sysroot |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Schvezov | Approve | ||
Daniel Holbach (community) | Needs Fixing | ||
Review via email: mp+271751@code.qastaging.launchpad.net |
Commit message
Ensure C library configuration tools don't use system paths
Description of the change
Creating a new dev box with Wily and realized that previously some deps were getting pulled from my system. Fixing them.
To post a comment you must log in.
Looks good, I'd just move the method to repo.Ubuntu.
Also a small integration or unit test would be great.