Code review comment for lp://qastaging/~ted/snapcraft/ros-catkin-plugin

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Hey good work on getting everything to this point. Seems like a really useful plugin. I do have some comments though.

I've been giving this a bit more of a look and I don't think we want config={} at all, parts should not have knowledge of config, it is what keeps them independent. We also don't want to have it write a services entry, that should be in the users control.

Last but not least, as elopio mentions, the code needs to be split out a bit.

review: Needs Fixing

« Back to merge proposal