Code review comment for lp://qastaging/~ted/snapcraft/ros-catkin-plugin
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
I've done a first pass, the code looks really good, just a couple nits here and there.
One thing we haven't been doing and I started addressing was that all our methods our public and I'd make them private (prefix the method with _), this becomes more important now that we inherit from plugins instead of 'requiring' them.