Code review comment for lp://qastaging/~teknico/desktopcouch/contacts-detailed-api

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Also, I do not quite understand the implications of setting and getting the values in the __dict__. Doesn't that mean they don't end up in the record's data?

If I do this:

foo = Contact()

foo.nick_name = 'Nick'
print foo.nick_name
print foo.keys()

I get:

Nick
['record_type']

and when I do the same on trunk, I get *exactly* the same results. Since the getter and setter don't do anything a normal python object doesn't already allow.

review: Needs Fixing

« Back to merge proposal