There a reason for all of the conversations to single quotes? Not an issue, exactly, but it feels like a Ruby-ish thing to do :-) Are you saying that single-quotes represent atom-like strings, where double-quotes are allowed to have inferred entities?
285 + Returns a tuple of (novaclient collection name, security
286 + context and resource id.
Missing trailing paren.
383 + :return: The host where instance is running currently.
384 + Then scheduler send request that host.
Missing article or pluralization?
416 + raise exception.Invalid(_('%s is not alive(time '
417 + 'synchronize problem?)') % src)
434 + raise exception.Invalid(_('%s is not alive(time '
435 + 'synchronize problem?)') % dest)
445 + raise exception.Invalid(_('%(dest)s is where %(ec2_id)s is '
446 + 'running now. choose other host.')
447 + % locals())
Given my original assumption, shouldn't these be double-quoted? There's more after this, as well. I don't think I should paste them all.
711 + """Picks a host that is up at random in zone."""
I think I prefer the original comment here. Perhaps at least some commas, if nothing else?
There a reason for all of the conversations to single quotes? Not an issue, exactly, but it feels like a Ruby-ish thing to do :-) Are you saying that single-quotes represent atom-like strings, where double-quotes are allowed to have inferred entities?
285 + Returns a tuple of (novaclient collection name, security
286 + context and resource id.
Missing trailing paren.
383 + :return: The host where instance is running currently.
384 + Then scheduler send request that host.
Missing article or pluralization?
416 + raise exception. Invalid( _('%s is not alive(time '
417 + 'synchronize problem?)') % src)
434 + raise exception. Invalid( _('%s is not alive(time '
435 + 'synchronize problem?)') % dest)
445 + raise exception. Invalid( _('%(dest) s is where %(ec2_id)s is '
446 + 'running now. choose other host.')
447 + % locals())
Given my original assumption, shouldn't these be double-quoted? There's more after this, as well. I don't think I should paste them all.
711 + """Picks a host that is up at random in zone."""
I think I prefer the original comment here. Perhaps at least some commas, if nothing else?